Update joni to 2.2.1 to fix regex match regression for 9.3#7884
Closed
skunkworker wants to merge 1 commit intojruby:jruby-9.3from
Closed
Update joni to 2.2.1 to fix regex match regression for 9.3#7884skunkworker wants to merge 1 commit intojruby:jruby-9.3from
skunkworker wants to merge 1 commit intojruby:jruby-9.3from
Conversation
skunkworker
changed the title
Member
|
@skunkworker from 2.1 to 2.2 some Region changes occurs. For whatever reason like JRuby the second digit indicates possible breakage. There is likely a set of region commits in JRuby which can "maybe" get cherry-picked back to 9.3. |
Member
|
Yeah 9.3 needs an update. I'll take care of it. |
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 15, 2023
* joni updated to 2.2.1 with the new Region factory and shapes. * strscan updated to a modified version of the gem 3.0.6 that can compile against joni 2.2 (which hides Region fields). Note that these changes mean any users depending on access to joni Region fields, or its constructor, will see some breakage, but these changes have been in the wild in 9.4.x for sevreal months without issues. Relates to jruby#7884
Member
Author
Thanks, I really appreciate it. |
Member
|
Sorry for all the open/closed noise! I keep forgetting this was a PR and not an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9.3.10.0 is currently broken with #7830. 9.3.9.0 is healthy. And
jonishould be updated in order to have a healthy9.3.11.0release in the future.