[fix] duplicate hash key literal removal#7882
Merged
kares merged 3 commits intojruby:masterfrom Aug 17, 2023
Merged
Conversation
kares
force-pushed
the
error-prone_left-over
branch
2 times, most recently
from
f3240f8 to
afec0cc
Compare
enebo
reviewed
Aug 14, 2023
kares
commented
Aug 16, 2023
getPairs().remove() passed a key which is always a noop
kares
force-pushed
the
error-prone_left-over
branch
from
d8a3eb5 to
637d2d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #7623, namely the detected collection usage issue: 0224d5d
While fixing the collection removal (type) issue I discovered that the actual AST node removal on duplicate hash keys is problematic (there's a need to evaluate the RHS even despite it's end result being thrown away), so the actual removal is still NOT happening.
**The PR still fixes the duplicate line reporting - will now point to the correct (duplicate) location as does MRI! **