Skip to content

Ruby 3.2 - Remove deprecated methods: trust/taint and friends#7871

Merged
enebo merged 1 commit intojruby:ruby-3.2from
edipofederle:remove-trust-traint-methods
Aug 1, 2023
Merged

Ruby 3.2 - Remove deprecated methods: trust/taint and friends#7871
enebo merged 1 commit intojruby:ruby-3.2from
edipofederle:remove-trust-traint-methods

Conversation

@edipofederle
Copy link
Contributor

@edipofederle edipofederle changed the base branch from master to ruby-3.2 July 31, 2023 11:49
@edipofederle edipofederle changed the title Ruby 3.2 - Removed deprecated methods: trust/taint and friends Ruby 3.2 - Remove deprecated methods: trust/taint and friends Jul 31, 2023
@enebo
Copy link
Member

enebo commented Jul 31, 2023

I want to just apply this but I also wonder if we should consider just removing the JRuby annotations? The reason for this is if any native extensions directly call these methods from Java then they will break. The methods do nothing but the number of people supporting the native extensions has lessened over the years and I just mildly fear it will require some people to rev some gems.

With that said this is for 3.2 so we could go about this the other way and actually check/contact all native extensions to make sure we can finally kill these methods off?

We will talk this over a bit before landing.

@edipofederle
Copy link
Contributor Author

Hi @enebo

Thanks make more sense for me to to just removing the JRuby annotations, let me know if ok for you so I can update the PR.

@headius
Copy link
Member

headius commented Jul 31, 2023

It looks like these Java methods were first deprecated in 9.4.0.0 so I'd lean toward just removing the annotations and leaving them in place for another major release (9.5 or whatever).

@edipofederle edipofederle force-pushed the remove-trust-traint-methods branch from 56641b3 to a82ea15 Compare July 31, 2023 20:19
@enebo enebo added this to the JRuby 9.5.0.0 milestone Aug 1, 2023
@enebo enebo merged commit 9593467 into jruby:ruby-3.2 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants