Make sure Ruby exception does not provide itself as cause.#7869
Merged
enebo merged 1 commit intojruby:masterfrom Aug 1, 2023
Merged
Make sure Ruby exception does not provide itself as cause.#7869enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
RubyException ends up getting called and it is used by RaiseException (which is a RuntimeException in Java). It seems like Ruby itself much less Java should have cause of an exception be itself. This should also prevent the Java exception from having the same condition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RubyException ends up getting called and it is used by RaiseException (which is a RuntimeException in Java). It seems like Ruby itself much less Java should have cause of an exception be itself. This should also prevent the Java exception from having the same condition?
This should fix #7861 but we shall see if anything complains or not in the expanded CI run.