Fixes #7854. Pattern matching with an empty hash should not match#7858
Merged
enebo merged 4 commits intojruby:masterfrom Jul 18, 2023
Merged
Fixes #7854. Pattern matching with an empty hash should not match#7858enebo merged 4 commits intojruby:masterfrom
enebo merged 4 commits intojruby:masterfrom
Conversation
This had two problems first was IR build was not realizing the
empty hash was actually empty. {} is still put into the AST
so we had to check that no elements are within that.
Second problem was missing logic to change the pattern error
string to 'is not empty'. This was a lesser issue since it
still returns a proper error but we may as well match the
strings.
```in **``` appeared the same as ```=> {}``` in a single
pattern match. MRI in parser is doing something I do not
comprehend with 0 vs none(). I decided to just make ```**```
explicit for kwrests in pattern matching. We already have
an interned object for the concept so I just used that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had two problems first was IR build was not realizing the empty hash was actually empty. {} is still put into the AST so we had to check that no elements are within that.
Second problem was missing logic to change the pattern error string to 'is not empty'. This was a lesser issue since it still returns a proper error but we may as well match the strings.