Fix recent regressions on master#7797
Merged
headius merged 7 commits intojruby:masterfrom May 23, 2023
Merged
Conversation
RubyKernel defines a different MethodMissingMethod that is the base of all special builtin method_missing methods.
This code worked ok to bind user-defined method_missing directly in the InvokeSite, but it breaks the production of a core method missing error by including the symbol name in that exceptions's arguments. We will revisit direct method_missing binding soon, once we refactor how this pipeline delivers arguments to both the exception and to user-defined method_missing methods. Fixes one regression due to invokedynamic, found by enabling more invokedynamic testing in jruby#7732.
The producers here are not prevented from running, which may lead to them completing before the status checks below. This in turn causes deprecation warnings when =~ is called on the false object. This also patches the status checks to avoid ever calling =~ on a non-stringlike object. See ruby/ruby#7830 for a more detailed explanation.
This spec was added to ensure that suspended fibers silently die when their parent thread is terminated, but we disagree as to whether thread-terminating events should trigger ensures in child threads. In JRuby, where fibers are backed by either an OS thread or a virtual thread, ensures currently will always run on the way out of a fiber, ensuring held resources are properly cleaned up. We tag this spec because we disagree with the assessment that ensures should not run for suspended fibers.
The cached build is built on Linux and is not set up properly to run on Windows like a release build would be. This prevented tests from running due to issues locating the jruby.exe file.
The non-release build does not appear to set up stdlib properly for cross-platform execution.
Fails in CI with indy enabled for unknown reasons. See jruby#7803.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.