Skip to content

Fix recent regressions on master#7797

Merged
headius merged 7 commits intojruby:masterfrom
headius:fix_master_ci
May 23, 2023
Merged

Fix recent regressions on master#7797
headius merged 7 commits intojruby:masterfrom
headius:fix_master_ci

Conversation

@headius
Copy link
Member

@headius headius commented May 18, 2023

No description provided.

headius added 2 commits May 18, 2023 10:06
RubyKernel defines a different MethodMissingMethod that is the
base of all special builtin method_missing methods.
This code worked ok to bind user-defined method_missing directly
in the InvokeSite, but it breaks the production of a core
method missing error by including the symbol name in that
exceptions's arguments. We will revisit direct method_missing
binding soon, once we refactor how this pipeline delivers
arguments to both the exception and to user-defined method_missing
methods.

Fixes one regression due to invokedynamic, found by enabling more
invokedynamic testing in jruby#7732.
@headius headius added this to the JRuby 9.4.3.0 milestone May 18, 2023
@headius headius mentioned this pull request May 18, 2023
22 tasks
The producers here are not prevented from running, which may lead
to them completing before the status checks below. This in turn
causes deprecation warnings when =~ is called on the false object.

This also patches the status checks to avoid ever calling =~ on a
non-stringlike object.

See ruby/ruby#7830 for a more detailed
explanation.
headius added 4 commits May 22, 2023 15:13
This spec was added to ensure that suspended fibers silently die
when their parent thread is terminated, but we disagree as to
whether thread-terminating events should trigger ensures in child
threads. In JRuby, where fibers are backed by either an OS thread
or a virtual thread, ensures currently will always run on the way
out of a fiber, ensuring held resources are properly cleaned up.
We tag this spec because we disagree with the assessment that
ensures should not run for suspended fibers.
The cached build is built on Linux and is not set up properly to
run on Windows like a release build would be. This prevented tests
from running due to issues locating the jruby.exe file.
The non-release build does not appear to set up stdlib properly
for cross-platform execution.
Fails in CI with indy enabled for unknown reasons.

See jruby#7803.
@headius headius marked this pull request as ready for review May 23, 2023 01:05
@headius headius merged commit a4a084b into jruby:master May 23, 2023
@headius headius deleted the fix_master_ci branch May 23, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant