[deps] update joda-time to latest 2.12.5#7794
Merged
Conversation
... which includes up-to-date IANA time-zone information
kares
commented
May 17, 2023
|
|
||
| # joda timezone must be before joda-time to be packed correctly | ||
| jar 'org.jruby:joda-timezones:${tzdata.version}', :scope => '${tzdata.scope}' | ||
| # jar 'org.jruby:joda-timezones:${tzdata.version}', :scope => '${tzdata.scope}' |
Member
Author
There was a problem hiding this comment.
believe this is redundant given the joda-time includes up-to-date tz-data and we want to make sure to use those
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
believe we should also release and update
tzdata.versionfrom 2019c to 2023cgtz (used in joda-time 2.12.2).I wonder if the
org.jruby:joda-timezonesmatters thought given the current 2019c version was not aligned withjoda-time2.10.10 which is meant to be using (packages inside the joda-time.jar) 2021a