Skip to content

Java call optimizations#7789

Merged
headius merged 1 commit intojruby:masterfrom
headius:improve_java_calls
May 23, 2023
Merged

Java call optimizations#7789
headius merged 1 commit intojruby:masterfrom
headius:improve_java_calls

Conversation

@headius
Copy link
Member

@headius headius commented May 12, 2023

This PR is for optimizations for calling Java methods from Ruby.

@headius headius added this to the JRuby 9.4.3.0 milestone May 12, 2023
@headius headius mentioned this pull request May 12, 2023
22 tasks
@headius headius marked this pull request as ready for review May 23, 2023 14:44
Still only supports one arity with no varargs or block conversion.
This code seems to have broken at some point as it used the wrong
signature to check for a block argument and did exactly the
wrong thing when comparing arity of a static or instance method.

This implements the first part of Java method call optimization
as mentioned in jrubyGH-7588.
@headius headius force-pushed the improve_java_calls branch from 30dd154 to e04e0f3 Compare May 23, 2023 14:45
@headius
Copy link
Member Author

headius commented May 23, 2023

Merging as is for 9.4.3. Additional work is details in #7588.

@headius headius merged commit 8ee2e4c into jruby:master May 23, 2023
@headius headius deleted the improve_java_calls branch May 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant