Fixes #7769. regexp with / before mbc should work.#7770
Merged
enebo merged 2 commits intojruby:masterfrom Apr 25, 2023
Merged
Conversation
Test case is: ```Regexp.new(%q{\§})``` (spec will be coming as
separate commit). Problem was we were missing mbc logic in
backslash processing. It would advance one too many times and
then only see half of the mbc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case is:
Regexp.new(%q{\§})(spec will be coming as separate commit). Problem was we were missing mbc logic in backslash processing. It would advance one too many times and then only see half of the mbc.I should have put this against 9.3.x as well but I will cherry-pick it back.