Fix BigDecimal(0, NAN and INFINITY) to return always same object#7768
Merged
enebo merged 2 commits intojruby:masterfrom Apr 29, 2023
Merged
Conversation
enebo
requested changes
Apr 23, 2023
Comment on lines
130
to
135
| private static RubyBigDecimal POSITIVE_ZERO; | ||
| private static RubyBigDecimal NEGATIVE_ZERO; | ||
| private static RubyBigDecimal POSITIVE_INFINITY; | ||
| private static RubyBigDecimal NEGATIVE_INFINITY; | ||
| private static RubyBigDecimal NAN; | ||
|
|
Member
There was a problem hiding this comment.
These cannot be static fields because:
- people with multiple Ruby runtimes in a single JVM will get values from other runtimes and bad things happen
- can potentially leak entire runtime since Runtime pins the entire system
Contributor
Author
There was a problem hiding this comment.
@enebo thanks for your review. i updated my PR using setConstant and setConstantVisibility.
Member
There was a problem hiding this comment.
If we notice a performance issue with constant table lookup here we can promote these to ordinary fields in some per-runtime Java object but this looks fine.
The following tests will pass. * test_BigDecimal_with_float in test/mri/bigdecimal/test_bigdecimal.rb
k77ch7
force-pushed
the
ruby-3.1-fix-bigdeciaml-zero-nan-infinity
branch
from
776d5b6 to
70e07d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following tests will pass.