Checking for size of outgoing and incoming edges of the vertex after removing a single edge#771
Merged
BanzaiMan merged 1 commit intojruby:masterfrom Jun 7, 2013
Merged
Conversation
ghost
assigned
Member
removing a single edge - After removing all incoming or outgoing edges, incoming or outgoing edges of a vertex are set to null - But after removing a single edge, it is not checked that outgoing of the source or incoming of the destination should be changed to null or not - This commit checks that condition and sets outgoing and incoming of source and destination respectively to null if the condition is met.
Contributor
Author
|
@BanzaiMan I rebased to master but it still failed for 1.9 https://travis-ci.org/jruby/jruby/jobs/7876718 & https://travis-ci.org/jruby/jruby/jobs/7876719 |
BanzaiMan
added a commit
that referenced
this pull request
Jun 7, 2013
Checking for size of outgoing and incoming edges of the vertex after removing a single edge
Member
|
On a second thought, the patch looks reasonable to me. I also added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edges of a vertex are set to null
the source or incoming of the destination should be changed to null
or not
source and destination respectively to null if the condition is met.