Define real error methods to avoid callee#7700
Merged
headius merged 5 commits intojruby:masterfrom Mar 1, 2023
Merged
Conversation
This was referenced Mar 1, 2023
The __callee__ versions of these methods do not work because our aliased method logic does not pass the new name along. Similar changes have been made elsewhere in the file. This relates to incomplete parsing issues as in jruby#7640 and fixes a large set of failure in the IRB lexer tests.
headius
force-pushed
the
ripper_error_callee
branch
2 times, most recently
from
bbc069a to
7345416
Compare
These need to be investigated but may be related to jruby#7640 and fixes in jruby#7700.
headius
force-pushed
the
ripper_error_callee
branch
from
7345416 to
a3537ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callee versions of these methods do not work because our aliased method logic does not pass the new name along. Similar changes have been made elsewhere in the file.
This relates to incomplete parsing issues as in #7640 and fixes a large set of failure in the IRB lexer tests.