Conversation
kares
left a comment
There was a problem hiding this comment.
Hey Andrea, you updated the pom.xml but the pom.rb is really the source of truth (pom.xml gets generated from the .rb version).
I would suggest to update the pom.rb line and run mvn package ... the xml should stay the same given you already have the changes.
|
Hi @kares ! thanks for checking :-D diff --git a/lib/pom.xml b/lib/pom.xml
index 63786be945..035ba65cbc 100644
--- a/lib/pom.xml
+++ b/lib/pom.xml
@@ -39,8 +39,8 @@ DO NOT MODIFY - GENERATED CODE
<scope>provided</scope>
<exclusions>
<exclusion>
- <groupId>rubygems</groupId>
<artifactId>jar-dependencies</artifactId>
+ <groupId>rubygems</groupId>
</exclusion>
</exclusions>
</dependency>Is it correct? Or after the |
|
@andsel At some point maven changed something and ordering of processing a Map changes the order (Ruby stuff is put into a Map and Java side walks it). A newer Maven will put it in the same order as we have it (we all made sure we were using newer maven at one point because we were playing ping pong with the generated xml files. If it is not possible to update maven let me know and we will merge this as-is and I will correct that ordering manually as part of the merge |
|
I merged this manually to avoid the reordering commit, and it is on master as of 4a1e6fc. Thanks for the help! |
Update
irbto version1.4.2because doesn't requirerdocmodule.Fixes #7690