All -I provided relative paths shold be made absolute#7683
Merged
enebo merged 4 commits intojruby:masterfrom Feb 21, 2023
Merged
All -I provided relative paths shold be made absolute#7683enebo merged 4 commits intojruby:masterfrom
enebo merged 4 commits intojruby:masterfrom
Conversation
We failed a test which assumed -I '.' would add '.' to LOAD_PATH. MRI will add the dir that '.' represents /home/enebo vs /home/enebo/. Canonicalizing this makes that match but this could yield an incompatibility with more exotic directories which link perhaps?
enebo
added a commit
to enebo/jruby
that referenced
this pull request
Mar 13, 2023
…y-complete. I need to still run this on windows itself but jruby#7683 only use File and not JRubyFile so it had no knowledge of uri:classpath files. It also was trying to canonicalize by default. Solution is to just get absolute path (still need to softlink test to show that -I will not canonicalize paths) and to not bother even testing if it is absolute since it is really doing same amount of work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All -I provided relative paths shold be made absolute