Fix #7672. warning about duplicated keys#7674
Merged
enebo merged 4 commits intojruby:masterfrom Feb 19, 2023
Merged
Conversation
Issue is in ordinary hash building this sort of duplication should be warned but in explicit kwargs they should not be. When we built hashes we did not differentiate between the two types. This is still missing testing.
A more general rule which has nothing specifically to do with keyword arguments but anything hash-like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is in ordinary hash building this sort of duplication should be warned but in explicit kwargs they should not be. When we built hashes we did not differentiate between the two types.
This is still missing testing.