Conversation
This condition essentially disabled this optimization altogether, since it would only fire if the receiver was a literal hash. It should run for all cases of obj["str"].
This brings coverage to 100% for ArrayDerefInvokeSite.
This is not well-optimized but now matches behavior from the interpreter; if the result of the `to_s` call is not a String, it should use anyToString on the original object. The `asString` helper does this, using the given call site (usually refined) to make the call.
Fail branches are not covered yet but they are not currently used due to the disabling of any caching.
If the string is prefrozen, we don't gain much with this optimization, so we just leave it as a normal call. Fixes remaining regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using coverage data to improve the testing in the compiler
general_spec.rb. These are the improvements.