Skip to content

Fix Array#fill for edge case#7651

Merged
headius merged 1 commit intojruby:jruby-9.3from
k77ch7:jruby-9.3-fix-array-fill
Feb 11, 2023
Merged

Fix Array#fill for edge case#7651
headius merged 1 commit intojruby:jruby-9.3from
k77ch7:jruby-9.3-fix-array-fill

Conversation

@k77ch7
Copy link
Contributor

@k77ch7 k77ch7 commented Feb 11, 2023

If start >= array.size and length = 0, array#fill should extends self with nil.

Fixes #7648

If start >= array.size and length = 0, array#fill should extends self with nil.

Fixes jruby#7648
@k77ch7 k77ch7 force-pushed the jruby-9.3-fix-array-fill branch from c372afc to 603ff16 Compare February 11, 2023 07:42
@k77ch7 k77ch7 changed the title Fix Array#fill if start >= array.size Fix Array#fill for edge case Feb 11, 2023
@headius
Copy link
Member

headius commented Feb 11, 2023

What a weird condition! Looks good, thanks!

@headius headius merged commit 64c3737 into jruby:jruby-9.3 Feb 11, 2023
@headius headius added this to the JRuby 9.3.11.0 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants