Use SmartBinder to set up struct calls#7643
Merged
headius merged 2 commits intojruby:masterfrom Feb 9, 2023
Merged
Conversation
Original logic used hardcoded argument offsets, which was broken by my work in jruby#7589 that removed the "caller" argument from self- calls that don't need to check visibility. The new logic uses SmartBinder and Signature to manipulate incoming arguments by name rather than by index. Fixes jruby#7642
Test both other- and self-calling, since it was self-calling that broke in jruby#7642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original logic used hardcoded argument offsets, which was broken by my work in #7589 that removed the "caller" argument from self- calls that don't need to check visibility.
The new logic uses SmartBinder and Signature to manipulate incoming arguments by name rather than by index.
Fixes #7642