Skip to content

add support for options and not truncating offset for IO.write#764

Merged
atambo merged 1 commit intojruby:masterfrom
josedonizetti:io_write
May 25, 2013
Merged

add support for options and not truncating offset for IO.write#764
atambo merged 1 commit intojruby:masterfrom
josedonizetti:io_write

Conversation

@josedonizetti
Copy link
Member

@josedonizetti josedonizetti commented May 25, 2013

No description provided.

@atambo
Copy link
Member

atambo commented May 25, 2013

This change introduces the following rubyspec error:

     [java] IO.write disregards other options if :open_args is given ERROR
     [java] IOError: not opened for writing
     [java] org/jruby/RubyIO.java:1369:in `write'
     [java] org/jruby/RubyIO.java:3771:in `write'
     [java] /home/travis/build/jruby/jruby/spec/ruby/core/io/write_spec.rb:61:in `(root)'
     [java] org/jruby/RubyBasicObject.java:1531:in `instance_eval'
     [java] org/jruby/RubyEnumerable.java:1343:in `all?'
     [java] org/jruby/RubyFixnum.java:280:in `times'
     [java] org/jruby/RubyArray.java:1617:in `each'
     [java] /home/travis/build/jruby/jruby/spec/ruby/core/io/write_spec.rb:48:in `(root)'
     [java] /home/travis/build/jruby/jruby/spec/ruby/core/io/write_spec.rb:47:in `(root)'
     [java] org/jruby/RubyKernel.java:1073:in `load'
     [java] org/jruby/RubyBasicObject.java:1531:in `instance_eval'
     [java] org/jruby/RubyArray.java:1617:in `each'

@josedonizetti
Copy link
Member Author

josedonizetti commented May 25, 2013

@atambo how did you simulate this error? Because my change is not supposed to make it happen, this error should be happening before because IO.write doesn't support "open_args" the specs for "open_args" are tagged. I was planing to support "open_args" after merging this pull request because make reviews easier.

atambo added a commit that referenced this pull request May 25, 2013
@atambo
Merge pull request #764 from josedonizetti/io_write
e812402 
add support for options and not truncating offset for IO.write
@atambo atambo merged commit e812402 into jruby:master May 25, 2013
@josedonizetti josedonizetti deleted the io_write branch May 25, 2013 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 1.7.5

Development

Successfully merging this pull request may close these issues.

2 participants

@josedonizetti @atambo