Cleanup IO state for true connect failures#7635
Merged
headius merged 1 commit intojruby:jruby-9.3from Feb 9, 2023
Merged
Conversation
When a connect_nonblock ultimately fails with one of these exceptions, we should tidy up the internal IO bits so it does not appear to be a usable stream. This lack of cleanup caused any call to `close` after a failed connection to raise EBADF, because the socket appeared to be open but was not. Fixes jruby#7483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a connect_nonblock ultimately fails with one of these exceptions, we should tidy up the internal IO bits so it does not appear to be a usable stream. This lack of cleanup caused any call to
closeafter a failed connection to raise EBADF, because the socket appeared to be open but was not.Fixes #7483