Small internal optimizations found profiling CSV#7619
Merged
headius merged 3 commits intojruby:masterfrom Feb 6, 2023
Merged
Conversation
headius
force-pushed
the
csv_optz
branch
3 times, most recently
from
f7abe0a to
5b112fc
Compare
kares
reviewed
Feb 6, 2023
These Ptr instances are only ever read or written under lock, so we can share them and reduce allocation along this hot path.
Co-authored-by: Karol Bucek <kares@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7604