Fixed launch jruby in MSYS2 environment#7601
Merged
headius merged 1 commit intojruby:masterfrom Jan 29, 2023
Merged
Conversation
Member
|
Thank you! I have no way to evaluate this right now, but it appears to be low risk to anything other than cygwin/mingw environments, which @knovok is clearly using. I assume this patch still works on msys? |
Contributor
Author
|
I tried not to hook other environments other than MSYS2. Cygwin should not break, as well as MSYS. The fix checks the environment ID from the /etc/os-release file. Even if the file does not exist (which should not be https://0pointer.de/blog/projects/os-release.html), the implementation will run without the patch. |
Member
|
Ok we'll go for it! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using MSYS2 environment.
jruby.exe is launched not from current directory but globally in system. Even if you run it from current directory, there will be no effect because jruby.exe does nothing but returns code 0.
In PR #37 was added launch jruby.exe of MSYS, but this is the first version of MSYS not MSYS2.