Remove a bad assert and untag some tests it was affecting#760
Merged
atambo merged 2 commits intojruby:masterfrom May 24, 2013
Merged
Remove a bad assert and untag some tests it was affecting#760atambo merged 2 commits intojruby:masterfrom
atambo merged 2 commits intojruby:masterfrom
Conversation
Seems this assert was typoed, and was accidentally asserting the nullness of something which is definitely not null. This was causing a number of false negatives when the tests were run with assertions enabled. Note that this commit completely removes the null checking since it can't do any good: this code would NPE earlier if line was null.
These were failing on CI due to a bad assert. Untag them now that the offending assert is gone. Note: there my be other tests which are also clean now that the assert is gone. Will check for them soon.
atambo
added a commit
that referenced
this pull request
May 24, 2013
Remove a bad assert and untag some tests it was affecting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, here's the spiritual successor to the aborted #757. Travis is happy!
I tracked down the difference between local runs and Travis runs to assertions being enabled on Travis. A bad assert was making enemies of a bunch of working specs.
I've organized this pull into two commits to make it easier to read: the actual code change and the subsequent test untagging. Note that there may be specs outside of
command_lineandcore/argfthat are also brought back to life by this; I'll have a look soon.