Set refinement bit before building closure#7595
Merged
headius merged 1 commit intojruby:masterfrom Jan 24, 2023
Merged
Conversation
The block passed to `refine` should itself see refined methods. The call was made here, but made after the block was already constructed. Moving the call up allows the block to pick up the refined bit. Fixes jruby#7526 Fixes jruby#7535
headius
force-pushed
the
who_refines_the_refiners
branch
from
259646a to
3d0dbb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block passed to
refineshould itself see refined methods. The call was made here, but made after the block was already constructed. Moving the call up allows the block to pick up the refined bit.This regressed at some point during 9.4 development.