Code was trying to make an int out of the kwargs hash.#7593
Merged
enebo merged 1 commit intojruby:masterfrom Jan 24, 2023
Merged
Code was trying to make an int out of the kwargs hash.#7593enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
Fixes jruby#7583. We have some fairly convoluted options processing for Dir.glob and Dir.[] which is shared. We were assuming #glob flags processing was active when we were processing #[] and trying to convert the options kwargs into an int value (boom). Renamed some stuff for clarity and fixed underlying problem. A rainy day job here would be to rewrite this method or possibly just make it two methods. I do not recommend this until our next kwargs design change. We may have a better interface for specifying kwargs which would make a significant part of this method not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7583. We have some fairly convoluted options processing for Dir.glob and Dir.[] which is shared. We were assuming #glob flags processing was active when we were processing #[] and trying to convert the options kwargs into an int value (boom).
Renamed some stuff for clarity and fixed underlying problem. A rainy day job here would be to rewrite this method or possibly just make it two methods. I do not recommend this until our next kwargs design change. We may have a better interface for specifying kwargs which would make a significant part of this method not exist.