Conversation
I've changed all of the relevant cases of anonymous KindOf classes to use the new JavaClassKindOf. This cuts down on some of the noise produced by anonymous inner classes, especially given that these replacement points all had identical implementations.
|
We fixed CI. Could you rebase this PR off the current master? Thanks. |
|
Hmm.. not building on the machine I've got currently. I'll be back on my dev machine Monday. Also, this PR still needs some additional benchmark lovin' before it is accepted. |
|
Removes 20 classes...very nice :-) Let us know when you think it's ready to merge. 0.7% degradation of kind_of is not a concern. |
|
Actually I went ahead and pulled this to run some numbers. My tests aren't exhaustive, but they show some interesting results: https://gist.github.com/headius/5748268 Summary: On Java 6, success cases for kind_of? degrade slightly, but failure cases improve. On Java 7, success cases are the same or faster, and failure cases are considerably faster. I'm going to run our test suites locally to ensure this is 100%, but otherwise I'll be merging it. If there's additional improvement possible, we can do it as separate PRs. |
|
Merged in bcc2674. |
2 participants
This pull request implements #614
I've performed the changes outlined in the issue description. Benchmarks show that the performance degradation is ~0.7%