Simplify logic in IRBuilder for keyword arguments.#7574
Merged
enebo merged 1 commit intojruby:masterfrom Jan 12, 2023
Merged
Conversation
Almost zero-sum but it allows define_method with kwargs definition to potentially be converted from a proc to a full method and it also checks for whether the fcall is 'using'. I don't think either of these current will play with kwargs but they may in the future and it is a little extra work to have some cleaner code.
enebo
added a commit
that referenced
this pull request
Jan 20, 2023
enebo
added a commit
that referenced
this pull request
Jan 23, 2023
edipofederle
pushed a commit
to edipofederle/jruby
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost zero-sum but it allows define_method with kwargs definition to potentially be converted from a proc to a full method and it also checks for whether the fcall is 'using'. I don't think either of these current will play with kwargs but they may in the future and it is a little extra work to have some cleaner code.