Fixes #7572. Blocks with only keywords losing keyword status.#7573
Merged
enebo merged 1 commit intojruby:masterfrom Jan 11, 2023
Merged
Fixes #7572. Blocks with only keywords losing keyword status.#7573enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
This was very narrow in scope. If you only passed in a single argument we "unwrap" it from the original ```[arg]``` and just pass arg. This in turn *spreads* whatever is there (if an array). In this case arg is the keywords arg. So the fix was to not unwrap in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was very narrow in scope. If you only passed in a single argument we "unwrap" it from the original
[arg]and just pass arg. This in turn spreads whatever is there (if an array).In this case arg is the keywords arg. So the fix was to not unwrap in this case.