[refactor] warnings which assumed a message is being passed#7571
Merged
kares merged 1 commit intojruby:masterfrom Feb 6, 2023
Merged
[refactor] warnings which assumed a message is being passed#7571kares merged 1 commit intojruby:masterfrom
kares merged 1 commit intojruby:masterfrom
Conversation
edipofederle
pushed a commit
to edipofederle/jruby
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
runtime.getWarnings().warnDeprecated(name)call was sometimes used as if it was passed a"message"... which leads to deprecated warnings such as
jruby -v -e 'puts lambda(&proc {})':(not the
" is deprecated"at the end - added by thewarnDeprecated(String)invocation)reviewed all places using
warnDeprecated(String)and started using anwarnDeprecated(ID, String)overload which passes the message - this means some places also have a better ID tag (although it isn't used that much).