Delegating methods must be able to set ruby2_keywords on delegate.#7561
Merged
enebo merged 1 commit intojruby:masterfrom Jan 6, 2023
Merged
Delegating methods must be able to set ruby2_keywords on delegate.#7561enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
alias and synchronized methods are only wrappers so they should mark their source methods as being ruby2_keywords. This also put setRuby2Keywords onto DynamicMethod to make it more clear this is a Ruby thing and not an IR-specific thing (IRMethodArgs as a cast is confusing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alias and synchronized methods are only wrappers so they should mark their source methods as being ruby2_keywords. This also put setRuby2Keywords onto DynamicMethod to make it more clear this is a Ruby thing and not an IR-specific thing (IRMethodArgs as a cast is confusing).