Skip to content

Etc#sysconf errors when it shouldn't#7559

Merged
headius merged 1 commit intojruby:jruby-9.3from
headius:etc_wierdness
Jan 6, 2023
Merged

Etc#sysconf errors when it shouldn't#7559
headius merged 1 commit intojruby:jruby-9.3from
headius:etc_wierdness

Conversation

@headius
Copy link
Member

@headius headius commented Jan 6, 2023

This is actually two fixes:

  1. errno() is not set to 0 by sysconf??? So while running spec:ruby:fast it would get set to something and a couple of sysconfs would return -1 but expect errno == 0. Kaboom.
  2. we did not obey semantics that ret == -1 and errno == 0 should return nil.

(backported from 9.4)

This is actually two fixes:
  1. errno() is not set to 0 by sysconf???  So while running spec:ruby:fast
     it would get set to something and a couple of sysconfs would return -1
     but expect errno == 0.  Kaboom.
  2. we did not obey semantics that ret == -1 and errno == 0 should return
     nil.
@headius headius added this to the JRuby 9.3.10.0 milestone Jan 6, 2023
@headius headius merged commit 06c92c6 into jruby:jruby-9.3 Jan 6, 2023
@headius headius deleted the etc_wierdness branch January 6, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants