[ji] revert Thread#to_java behavior to stay compatible, for now#7557
Merged
headius merged 2 commits intojruby:masterfrom Jan 27, 2023
Merged
[ji] revert Thread#to_java behavior to stay compatible, for now#7557headius merged 2 commits intojruby:masterfrom
headius merged 2 commits intojruby:masterfrom
Conversation
Member
|
@kares Is it possible to add a native_thread method to j.l.Thread? I think it is possible someone will be doing that out in the wild and we were definitely depending on that method in the test. |
follow-up on be88ae1 Thread#to_java changes are from jrubyGH-7549 (bfa1451)
kares
force-pushed
the
ji-thread-to-java++
branch
from
1adf6b7 to
14296c7
Compare
kares
changed the title
follow up on bfa1451
kares
force-pushed
the
ji-thread-to-java++
branch
from
14296c7 to
a4eee01
Compare
Member
|
I think we are all on board with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following up on
Thread#to_javachanges from GH-7549 (bfa1451)also follow-up on be88ae1 to un-pend existing tests
actual deprecation and change of
Thread#to_javato be carried out at #7568