UnboundMethod#bind should introduce include class#7555
Merged
headius merged 2 commits intojruby:jruby-9.3from Jan 5, 2023
Merged
UnboundMethod#bind should introduce include class#7555headius merged 2 commits intojruby:jruby-9.3from
headius merged 2 commits intojruby:jruby-9.3from
Conversation
headius
force-pushed
the
unbound_super_9.3
branch
from
4ea907e to
042d706
Compare
When the incoming UnboundMethod is from a Module not already included in the target receiver's class hierarchy, the newly bound Method should treat that method as living in a virtual module included below the receiver's class. This allows the rebound method to use `super` to call a method of the same name in the receiver's hierarchy. For the original change in CRuby (2.2) see: ruby/ruby@46f578d For the additional change to avoid the extra include class when the owner module is already in the target hierarchy, see: ruby/ruby@160b67d Fixes jruby#7548.
headius
force-pushed
the
unbound_super_9.3
branch
from
042d706 to
cdd9ee1
Compare
Member
Author
|
The failures are not due to my patch, and must mean GHA has updated to an environment that triggers these issues. I will merge this and look into those separately. |
headius
added a commit
to headius/jruby
that referenced
this pull request
Jan 5, 2023
Additional change for bind_call to allow supering out of rebound methods. See jruby#7555. Fixes jruby#7548 for 9.4.
edipofederle
pushed a commit
to edipofederle/jruby
that referenced
this pull request
Feb 8, 2023
Additional change for bind_call to allow supering out of rebound methods. See jruby#7555. Fixes jruby#7548 for 9.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the incoming UnboundMethod is from a Module not already
included in the target receiver's class hierarchy, the newly bound
Method should treat that method as living in a virtual module
included below the receiver's class. This allows the rebound
method to use
superto call a method of the same name in thereceiver's hierarchy.
For the original change in CRuby (2.2) see:
ruby/ruby@46f578d
For the additional change to avoid the extra include class when
the owner module is already in the target hierarchy, see:
ruby/ruby@160b67d
Fixes #7548.