UnboundMethod#bind should use virtual include class for module methods#7551
Merged
headius merged 2 commits intojruby:masterfrom Jan 5, 2023
Merged
Conversation
enebo
approved these changes
Jan 5, 2023
Additional change for bind_call to allow supering out of rebound methods. See jruby#7555. Fixes jruby#7548 for 9.4.
UnboundMethod#bind and #bind_call should bind to a virtual include class below the receiver class when the method is from a module that does not exist in the receiver's hierarchy. This allows the rebound method to call `super` to delegate to the receiver's class and ancestors. This behavioral change was introduced when `bind_call` was added but I have not found any tests, specs or documentation about the behavior change. See jruby#7548 and sorbet/sorbet#1188.
headius
force-pushed
the
unboundmethod_bind_to_includeclass
branch
from
7c9d63e to
867aa9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When binding a module method to a receiver that does not already include that module, the bound method (and the call entry used for bind_call) should act as though that method were included into a virtual module below the receiver class. This allows bound module methods to super into the receiver class.
This behavior was introduced when
bind_callwas added, but affects bothbindandbind_calland does not appear to have been documented or tested. It went on to be used in Sorbet, which resulted in a bug report on JRuby in sorbet/sorbet#1188.This should fix that issue and the JRuby bug reported recently as #7548.
This issue does not affect JRuby 9.3 because
bind_callwas introduced in 2.7.