Fixes #7492. define_method should use definition scope.#7536
Merged
enebo merged 1 commit intojruby:masterfrom Dec 22, 2022
Merged
Fixes #7492. define_method should use definition scope.#7536enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
So the basic problem is that (only in the interpreter) we would emit the name of the method/define_method in backtraces instead of the name where the block was originally conceived (lexical location). This issue has been strange for 3 reasons: 1. JIT/FORCE works. It generates backtraces differently. 2. mocha tests run in 9.3 in spite of this issue (something else happens) 3. As far as I can tell we have always been incompatible (9.2 at least)
floehopper
added a commit
to freerange/mocha
that referenced
this pull request
Apr 9, 2023
This reverts commit b8e6d06. The problem identified in #591 was reported and investigated in jruby/jruby#7492, fixed in jruby/jruby#7536 and released in JRuby v9.4.1.0 [1]. The latest JRuby release is v9.4.2.0, so reverting the commit which pinned the JRuby version should now work. Fixes #591. [1]: https://github.com/jruby/jruby/releases/tag/9.4.1.0
floehopper
added a commit
to freerange/mocha
that referenced
this pull request
Apr 9, 2023
This reverts commit b8e6d06. The problem identified in #591 was reported and investigated in jruby/jruby#7492, fixed in jruby/jruby#7536 and released in JRuby v9.4.1.0 [1]. The latest JRuby release is v9.4.2.0, so reverting the commit which pinned the JRuby version now works. Fixes #591. [1]: https://github.com/jruby/jruby/releases/tag/9.4.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the basic problem is that (only in the interpreter) we would emit the name of the method/define_method in backtraces instead of the name where the block was originally conceived (lexical location).
This issue has been strange for 3 reasons: