Enumerator#inspect: Use String concatenation not just bytelist appends#7531
Merged
enebo merged 1 commit intojruby:masterfrom Dec 16, 2022
Merged
Enumerator#inspect: Use String concatenation not just bytelist appends#7531enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
This is really weird that it is ASCII-8BIT by default but if you inspect something which inside of the enumerator is UTF-8 then the result string should also be UTF-8.
cboos
added a commit
to cboos/jruby
that referenced
this pull request
Dec 17, 2022
"Enumerator#inspect produces an ASCII-8BIT encoded String" This was fixed by PR jruby#7531 "Enumerator#inspect: Use String concatenation not just bytelist appends"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really weird that it is ASCII-8BIT by default but if you inspect something which inside of the enumerator is UTF-8 then the result string should also be UTF-8.
This fixes #7529