Skip to content

Define IO::READABLE, WRITABLE, PRIORITY for IO#wait#7523

Merged
headius merged 2 commits intojruby:masterfrom
headius:io_wait_constants
Feb 13, 2024
Merged

Define IO::READABLE, WRITABLE, PRIORITY for IO#wait#7523
headius merged 2 commits intojruby:masterfrom
headius:io_wait_constants

Conversation

@headius
Copy link
Member

@headius headius commented Dec 14, 2022

These are to be used by the io-wait library, but there will be some lag before I can figure out how to make them honor these values without breaking backward compatibility with 9.4.0.0.

@headius headius added this to the JRuby 9.4.1.0 milestone Dec 14, 2022
@headius headius marked this pull request as ready for review December 14, 2022 10:24
@headius headius modified the milestones: JRuby 9.4.1.0, JRuby 9.4.2.0 Feb 6, 2023
@headius headius modified the milestones: JRuby 9.4.2.0, JRuby 9.4.3.0 Feb 28, 2023
@headius headius modified the milestones: JRuby 9.4.3.0, JRuby 9.4.4.0 Jun 6, 2023
@headius
Copy link
Member Author

headius commented Oct 11, 2023

Do this whenever #7944 lands.

@headius headius modified the milestones: JRuby 9.4.4.0, JRuby 9.4.5.0 Oct 11, 2023
@enebo enebo modified the milestones: JRuby 9.4.5.0, JRuby 9.4.6.0 Oct 31, 2023
As part of moving toward the scheduler API, several methods from
the io-wait gem have been moved into IO proper.

Preliminary support for the scheduler API was merged in jruby#7944.
@headius
Copy link
Member Author

headius commented Feb 13, 2024

The missing magic was to also move the io-wait methods wait, wait_readable, and wait_writable into IO proper, since they are moving out of the io-wait gem in CRuby.

@headius headius merged commit 2e59e70 into jruby:master Feb 13, 2024
@headius headius deleted the io_wait_constants branch February 13, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants