Merged
Conversation
Since checkArity happens before IR is executed AND the extra argument
is dropped by a specific arity method before IR starts executing; we will
add logic to detect **{} into a different version of IR helper check arity
to not raise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largely removing more old design setting of values that IRBuilder was calculating before any instructions were executed.
The JIT fixes revolve around specific arity generated methods needing to run checkArity before executing the method body. This is the only place we can see an additional **{} as it will be stripped off before we could execute instrs.