Fix syntax error in all cases where & is a param.#7509
Merged
enebo merged 1 commit intojruby:masterfrom Dec 2, 2022
Merged
Conversation
The primary fix here is to make a new subtype to tell whether we are using FWD_BLOCK or not (ForwaringBlockArgNode). Secondary clarifier is to make ANON_BLOCK to complement FWD_BLOCK (both are '&'). The irony of the check is this is for a warning of something like: def foo(*r, ...); end Notice '&' is not even in this signature. They use existence of '&' as a proxy for '...'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary fix here is to make a new subtype to tell whether we are using FWD_BLOCK or not (ForwaringBlockArgNode). Secondary clarifier is to make ANON_BLOCK to complement FWD_BLOCK (both are '&').
The irony of the check is this is for a warning of something like: def foo(*r, ...); end
Notice '&' is not even in this signature. They use existence of '&' as a proxy for '...'.
Fixes #7506