[refactor] make Java embed utils generic#7503
Merged
kares merged 5 commits intojruby:masterfrom Feb 6, 2023
Merged
Conversation
Member
Author
|
hmm, wonder if I should target 9.3 branch, the iface fix would be nice to have there but still isn't super crucial ... |
Member
|
JRuby 9.3 will be maintained for the next year, so if you think this is valuable to have there we should retarget. |
Member
Author
|
yeah, already did cherry-pick the fix commit for 9.3: #7514 (for the refactorings I have no strong opinions) |
kares
force-pushed
the
fix-jembed-utils
branch
from
87a867b to
5acbfa0
Compare
kares
changed the title
Member
Author
|
update the PR, since #7514 got merged over, now it's mostly just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the main thing is to fix an issue withjava_aliasthat did not work with interfaces (included test errors with aClassCastExceptionusing JRuby 9.3.9.0).ended up in a code base that uses
JavaEmbedUtils'sinvokeMethodandrubyToJava, and require and extra cast which seemed like a missed opportunity 😉