one-time-execute can sometimes contain a closure. guard it.#7493
Merged
enebo merged 1 commit intojruby:masterfrom Nov 28, 2022
Merged
one-time-execute can sometimes contain a closure. guard it.#7493enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
in irb we get a scenarion where we delete parent scope of a closure because at the time we delete it we do not know a closure will exist. The fix is a trivial bullet-proof test line. Our actual code calling prepareForCompilation already is aware that null fic is a failure case.
Member
Author
|
Note fixes #7486 |
Member
Author
|
for whatever reason jit for java 11 is flaking out but all this PR could do is not cause JRuby to crash so it has to be unrelated (unless these tests never really run at all and crashing somehow is showing it as a pass). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in irb we get a scenarion where we delete parent scope of a closure because at the time we delete it we do not know a closure will exist. The fix is a trivial bullet-proof test line. Our actual code calling prepareForCompilation already is aware that null fic is a failure case.