Fix precision issues in Time by avoiding conversions to nanoseconds. #745
Merged
headius merged 3 commits intojruby:masterfrom May 21, 2013
Merged
Fix precision issues in Time by avoiding conversions to nanoseconds. #745headius merged 3 commits intojruby:masterfrom
headius merged 3 commits intojruby:masterfrom
Conversation
Calculations using Time are done to the nanosecond. When using dates, the Unix time converted into nanosecond is too big (in absolute value) to fit in a `long`. The idea in this fix is to separate the millisecond calculation from the nanosecond one to avoid converting these dates into nanoseconds.
headius
added a commit
that referenced
this pull request
May 21, 2013
Fix precision issues in Time by avoiding conversions to nanoseconds.
Member
|
CI is in a weird state, but your code looks fine. Merging and will test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #652
Calculations using Time are done to the nanosecond. When using dates,
the Unix time converted into nanosecond is too big (in absolute value)
to fit in a
long. The idea in this fix is to separate the millisecondcalculation from the nanosecond one to avoid converting these dates
into nanoseconds.