Skip to content

[deps] update Bundler/Rubygems to latest patch#7401

Merged
kares merged 2 commits intojruby-9.3from
kares-patch-1
Oct 13, 2022
Merged

[deps] update Bundler/Rubygems to latest patch#7401
kares merged 2 commits intojruby-9.3from
kares-patch-1

Conversation

@kares
Copy link
Member

@kares kares commented Oct 7, 2022

closing #7397

@kares kares linked an issue Oct 7, 2022 that may be closed by this pull request
@kares
Copy link
Member Author

kares commented Oct 7, 2022

seems stdlib grows considerably (few hundred kb) when latest Bundler/Rubygems gets included:
size of lib/target/jruby-stdlib-9.3.9.0-SNAPSHOT.jar expected smaller then 13*1024*1024 but got 14359221

@kares
Copy link
Member Author

kares commented Oct 10, 2022

looking into this, stdlib was right at the edge of collapse already (before this change which adds a few kb):

  File: jruby-stdlib-9.3.9.0-SNAPSHOT.jar
  Size: 14319811

... at 13,984k

@kares
Copy link
Member Author

kares commented Oct 10, 2022

size increase is mainly caused by updating jruby-openssl to 0.14
the gem (due upgraded BC jars in 0.14.0) has grown from 7.79MB to 8.58MB

@kares kares added this to the JRuby 9.3.9.0 milestone Oct 10, 2022
@chadlwilson
Copy link
Contributor

Be afraid about BouncyCastle 1.72 coming jruby-openssl's way at some point in the future then - the provider jar went up over 5MB on top of 1.71 due to addition of post-quantum crypto algorithms :'(

@enebo
Copy link
Member

enebo commented Oct 11, 2022

@chadlwilson yeah that is unfortunate but we mostly are concerned enough to have a file size check because in the past we have accidentally included files we shouldn't. So once we know the expected size we will just increase our check number and not fret too much about it.

@headius
Copy link
Member

headius commented Oct 12, 2022

All seems good to me. We will prioritize moving away from BC in 2023 but we don't have the resources to do it right now.

@kares kares merged commit a0bccd8 into jruby-9.3 Oct 13, 2022
@kares kares deleted the kares-patch-1 branch October 13, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update bundler in jruby-complete

4 participants