Fix PTY.spawn using libfixposix#7393
Merged
headius merged 8 commits intojruby:masterfrom Nov 17, 2022
Merged
Conversation
Member
Author
|
I've been using the change in Ruby.java to test the end-to-end path as there aren't any pty.spawn tests here, but I'm not sure about leaving it or if it should be that method of configuration for now |
headius
approved these changes
Nov 17, 2022
Member
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
Looks good. Talked through default gem setup and windows warning and I think the rest is fine and we can iterate if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6552
This, combined with the new gems and ruby/io-console#35 should allow PTY.spawn to work on all *nix systems.
TO-DO list:
This can also be used to fix older versions of JRuby as the fix is gemified