Also include/prepend into existing include hiers#7377
Merged
headius merged 2 commits intojruby:masterfrom Sep 27, 2022
Merged
Conversation
When including or prepending a module Y into a module X, we must also visit hierarchies that include X and add Y to them so they reflect the change.
headius
changed the title
Member
Author
|
I fixed the only failures that were actually related to this, in our own test_method_cache where we expected future includes would not be honored by existing classes. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When including or prepending a module Y into a module X, we must also visit hierarchies that include X and add Y to them so they reflect the change.