Fixes Time.at argument handling (#7265)#7359
Merged
enebo merged 2 commits intojruby:jruby-9.3from Sep 13, 2022
Merged
Conversation
This version of the fix makes arg3 = :microseconds as a default value similar to Ruby (Time#at is now impld in Ruby and is this way).
This only happens unnaturally by intermediate methods which already know the third argument is either really the options hash OR it was not provided at all (varargs caller). Replace using nil with null in atOpts which upon seeing null will set the value to :microseconds. If it is nil it will blow up as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version of the fix for #7265 makes arg3 = :microseconds as a default value similar to Ruby (Time#at is now impld in Ruby and is this way).