Skip to content

Fix for method visibility changes super_method for module-inherited methods#7356

Merged
headius merged 3 commits intojruby:jruby-9.3from
evaniainbrooks:7344-fix-super-method
Sep 13, 2022
Merged

Fix for method visibility changes super_method for module-inherited methods#7356
headius merged 3 commits intojruby:jruby-9.3from
evaniainbrooks:7344-fix-super-method

Conversation

@evaniainbrooks
Copy link
Contributor

@evaniainbrooks evaniainbrooks commented Sep 10, 2022

closes #7344

@evaniainbrooks evaniainbrooks marked this pull request as ready for review September 10, 2022 14:26
@headius
Copy link
Member

headius commented Sep 12, 2022

This looks great, thank you! Could you clean up the few rogue whitespace issues? We try to avoid committing small whitespace changes because they end up flipping back and forth as people use different formatting standards.

@headius
Copy link
Member

headius commented Sep 12, 2022

Put a bit differently... if there are no functional changes on a given line, there should be no whitespace changes. I see a few places where tabs got (correctly) replaced with spaces on or near lines that actually had behavior changes, and those would be fine to include.

@headius headius merged commit ee61f43 into jruby:jruby-9.3 Sep 13, 2022
@headius
Copy link
Member

headius commented Sep 13, 2022

Much better, thanks! This is merged, and after your other PR runs another CI (I had to manually merge the test changes) we'll be good there too!

@evaniainbrooks evaniainbrooks deleted the 7344-fix-super-method branch September 21, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants