Fix for method visibility changes super_method for module-inherited methods#7356
Merged
headius merged 3 commits intojruby:jruby-9.3from Sep 13, 2022
Merged
Conversation
dceb22e to
00d577d
Compare
Member
|
This looks great, thank you! Could you clean up the few rogue whitespace issues? We try to avoid committing small whitespace changes because they end up flipping back and forth as people use different formatting standards. |
Member
|
Put a bit differently... if there are no functional changes on a given line, there should be no whitespace changes. I see a few places where tabs got (correctly) replaced with spaces on or near lines that actually had behavior changes, and those would be fine to include. |
Member
|
Much better, thanks! This is merged, and after your other PR runs another CI (I had to manually merge the test changes) we'll be good there too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7344