Fix for changing method visibility changes behavior for module-inherited methods#7343
Merged
headius merged 3 commits intojruby:jruby-9.3from Sep 13, 2022
Conversation
evaniainbrooks
changed the title
evaniainbrooks
force-pushed
the
7240-changing-method-visibility-changes-behavior
branch
from
090dc9c to
8a2e858
Compare
Member
|
Same minor issue here as in #7356; don't commit global whitespace changes... only correct whitespace changes on lines that have functional changes in the patch. Great work otherwise, thank you! |
evaniainbrooks
force-pushed
the
7240-changing-method-visibility-changes-behavior
branch
from
8a2e858 to
2f1b6cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7240