defined reified classes with their parent class's classloader as parent#7332
Merged
headius merged 1 commit intojruby:jruby-9.3from Sep 12, 2022
Merged
Conversation
ccutrer
force-pushed
the
reified_parent_not_in_system_classloader
branch
2 times, most recently
from
12cd837 to
02f5e6b
Compare
Contributor
Author
|
The check failure appears to be a simple timeout in unrelated code. This seems to be working, but would welcome any feedback on the approach. Especially the part where I'm not using the MultiClassLoader if useChildLoader is false. |
ccutrer
force-pushed
the
reified_parent_not_in_system_classloader
branch
from
02f5e6b to
a4ea902
Compare
Member
|
Yeah this looks fine. Thanks! |
ccutrer
force-pushed
the
reified_parent_not_in_system_classloader
branch
from
a4ea902 to
d7a87d4
Compare
Contributor
Author
|
I'm happy with this now, and ready for review. |
Contributor
Author
|
@headius: are you waiting for anything else from me on this PR? |
Member
|
Nope this looks logical and correct! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7327