Fix issue #7316 runtime error when nested raise#7321
Merged
enebo merged 3 commits intojruby:jruby-9.3from Aug 24, 2022
Merged
Conversation
Member
|
This fix looks good at a glance, but we should target the Thanks for the help on this! |
Member
|
Am I reading this right? It seems like CRuby allows the circular cause to be created, but avoids recursing forever when displaying it by using a set? |
This reverts commit bd2595c.
evaniainbrooks
force-pushed
the
7316-runtime-error-when-nested-raise
branch
from
b325f87 to
9f78cd1
Compare
Contributor
Author
|
@headius Yes, that is the conclusion I came to after reviewing how this was solved in CRuby. I've rebased branch to 9.3, cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #7316
Revert d2d594f and use similar approach from CRuby: ruby/ruby@1849288